Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove rtc staus when no avoidance candidate is output #1636

Merged
merged 5 commits into from
Aug 22, 2022
Merged

fix: remove rtc staus when no avoidance candidate is output #1636

merged 5 commits into from
Aug 22, 2022

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Aug 19, 2022 •
edited
Loading

Signed-off-by: tomoya.kimura [email protected]

Description

Fixed a bug that avoidance's rtc_status is continuously output even if avoidance is canceled and no candidate route is output.

Check

Please confirm that rtc-status output stops properly when avoidance is cancelled.
$ros2 topic echo /api/external/get/rtc_status

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@tkimura4 tkimura4 requested a review from rej55 August 19, 2022 09:45
@tkimura4
Copy link
Contributor Author

Result:
https://user-images.githubusercontent.com/59680180/185597652-f0f872bb-a947-41ba-b2ef-ef774600036a.mp4
https://user-images.githubusercontent.com/59680180/185597662-6f457cd6-f390-4d82-8bbe-ab4058f058fd.mp4

@codecov
Copy link

codecov bot commented Aug 19, 2022 •
edited
Loading

Codecov Report

Merging #1636 (d88adfa) into main (020c6d8) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1636      +/-   ##
==========================================
- Coverage   10.68%   10.51%   -0.18%     
==========================================
  Files        1109     1101       -8     
  Lines       78600    72445    -6155     
  Branches    18547    18212     -335     
==========================================
- Hits         8398     7616     -782     
+ Misses      61341    56217    -5124     
+ Partials     8861     8612     -249
Flag Coverage Δ *Carryforward flag
differential 0.78% <0.00%> (?)
total 10.59% <0.00%> (-0.08%) ⬇️ Carriedforward from 5bbf257

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
..._ad_api_msgs/msg/response_status__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
...d_api_msgs/srv/interface_version__type_support.cpp 0.00% <0.00%> (-54.55%) ⬇️
.../_autoware_ad_api_msgs_s.ep.rosidl_typesupport_c.c 0.00% <0.00%> (-47.46%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
...l/dds_fastrtps/interface_version__type_support.cpp 0.00% <0.00%> (-32.72%) ⬇️
...s/srv/detail/interface_version__type_support_c.cpp 0.00% <0.00%> (-31.00%) ⬇️
... and 706 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tkimura4 tkimura4 marked this pull request as ready for review August 19, 2022 10:46
tkimura4 and others added 3 commits August 22, 2022 12:30
@tkimura4 @rej55
Update planning/behavior_path_planner/include/behavior_path_planner/s…
ed42cc6 
…cene_module/avoidance/avoidance_module.hpp

Co-authored-by: Fumiya Watanabe <[email protected]>
@tkimura4 @rej55
Update planning/behavior_path_planner/src/scene_module/avoidance/avoi…
fbe4cba 
…dance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>
@tkimura4 @rej55
Update planning/behavior_path_planner/src/scene_module/avoidance/avoi…
d88adfa 
…dance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>
@tkimura4 tkimura4 requested a review from rej55 August 22, 2022 03:30
taikitanaka3
taikitanaka3 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rej55
rej55 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 1115898 into autowarefoundation:main Aug 22, 2022
@rej55 rej55 deleted the fix/avoidance_rtc branch August 22, 2022 04:31
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Aug 22, 2022
@tkimura4 @rej55
fix: remove rtc staus when no avoidance candidate is output (autoware…
da0d13a 
…foundation#1636)

* fix: remove rtc staus when no avoidance candidate is output

Signed-off-by: tomoya.kimura <[email protected]>

* remove only candidate rtc status

Signed-off-by: tomoya.kimura <[email protected]>

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Aug 23, 2022
Merged
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
@tkimura4 @rej55 @boyali
fix: remove rtc staus when no avoidance candidate is output (autoware…
79a64c9 
…foundation#1636)

* fix: remove rtc staus when no avoidance candidate is output

Signed-off-by: tomoya.kimura <[email protected]>

* remove only candidate rtc status

Signed-off-by: tomoya.kimura <[email protected]>

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
@tkimura4 @rej55 @boyali
fix: remove rtc staus when no avoidance candidate is output (autoware…
a4f84b1 
…foundation#1636)

* fix: remove rtc staus when no avoidance candidate is output

Signed-off-by: tomoya.kimura <[email protected]>

* remove only candidate rtc status

Signed-off-by: tomoya.kimura <[email protected]>

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
@tkimura4 @rej55 @boyali
fix: remove rtc staus when no avoidance candidate is output (autoware…
5c3ab0b 
…foundation#1636)

* fix: remove rtc staus when no avoidance candidate is output

Signed-off-by: tomoya.kimura <[email protected]>

* remove only candidate rtc status

Signed-off-by: tomoya.kimura <[email protected]>

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@tkimura4 @rej55
fix: remove rtc staus when no avoidance candidate is output (autoware…
1cb4e6e 
…foundation#1636)

* fix: remove rtc staus when no avoidance candidate is output

Signed-off-by: tomoya.kimura <[email protected]>

* remove only candidate rtc status

Signed-off-by: tomoya.kimura <[email protected]>

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
@tkimura4 @rej55 @boyali
fix: remove rtc staus when no avoidance candidate is output (autoware…
fcdca22 
…foundation#1636)

* fix: remove rtc staus when no avoidance candidate is output

Signed-off-by: tomoya.kimura <[email protected]>

* remove only candidate rtc status

Signed-off-by: tomoya.kimura <[email protected]>

* Update planning/behavior_path_planner/include/behavior_path_planner/scene_module/avoidance/avoidance_module.hpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

* Update planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Fumiya Watanabe <[email protected]>

Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rej55 rej55 rej55 approved these changes

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkimura4 @rej55 @taikitanaka3